[webkit-reviews] review granted: [Bug 234570] Web Inspector: Assertion Failed adding event listener in CSSPropertyNameCompletions.prototype._updateValuesWithLatestCSSVariablesIfNeeded : [Attachment 447736] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 234570: Web Inspector: Assertion Failed adding event listener in
CSSPropertyNameCompletions.prototype._updateValuesWithLatestCSSVariablesIfNeede
d
https://bugs.webkit.org/show_bug.cgi?id=234570

Attachment 447736: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=447736&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 447736
  --> https://bugs.webkit.org/attachment.cgi?id=447736
Patch v1.0

r=me, this is perhaps maybe slightly more inefficient cause we're now listening
for `WI.DOMNodeStyles.Event.NeedsRefresh` even if we haven't called
`allCSSVariables` yet, but I think it's fine