[webkit-reviews] review granted: [Bug 234533] Remove Web Authentication as experimental feature flag : [Attachment 447722] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 234533: Remove Web Authentication as experimental feature flag
https://bugs.webkit.org/show_bug.cgi?id=234533

Attachment 447722: Patch

https://bugs.webkit.org/attachment.cgi?id=447722&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 447722
  --> https://bugs.webkit.org/attachment.cgi?id=447722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447722&action=review

r=me. So nice to see tons of code deleted!

> Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:-503
> -WK_EXPORT bool WKPreferencesGetWebAuthenticationEnabled(WKPreferencesRef);

Ordinarily we would want to make this a stub and deprecate it, but I don't find
any uses of this call in other (non-WebKit) software so I think this is okay.

>
LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
7
> +navigator.credentials is OK

I assume the WebAuthn bits of navigator.credentials aren't present in WK1, but
the top-level namespace exists?