[webkit-reviews] review granted: [Bug 234404] WebsiteDataStore::excludeDirectoryFromBackup should set attribute for existing directories : [Attachment 447618] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 234404: WebsiteDataStore::excludeDirectoryFromBackup should set attribute
for existing directories
https://bugs.webkit.org/show_bug.cgi?id=234404

Attachment 447618: Patch

https://bugs.webkit.org/attachment.cgi?id=447618&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 447618
  --> https://bugs.webkit.org/attachment.cgi?id=447618
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447618&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:649
> +    if (![url setResourceValue:@YES forKey:NSURLIsExcludedFromBackupKey
error:nil])

It would be good to log error.
Maybe write something like
[url setResourceValue:@YES forKey:NSURLIsExcludedFromBackupKey error:error];
RELEASE_LOG_ERROR_IF(error, Storage, ... +log error).

> Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:463
> +    [[NSFileManager defaultManager] removeItemAtPath:url.absoluteString
error:nil];

Should we create the directory without the key to make sure the new code path
makes it working?