[webkit-reviews] review denied: [Bug 234547] [RISCV64] Add RISCV64 support in YARR : [Attachment 447692] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 234547: [RISCV64] Add RISCV64 support in YARR
https://bugs.webkit.org/show_bug.cgi?id=234547

Attachment 447692: Patch

https://bugs.webkit.org/attachment.cgi?id=447692&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 447692
  --> https://bugs.webkit.org/attachment.cgi?id=447692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447692&action=review

Nice

> Source/JavaScriptCore/ChangeLog:10
> +	   with other 64-bit architectures.

I think you also need to flip some flags in PlatformEnable.h (YarrJIT feature
flags for rich 64bit architectures. e.g. ENABLE_YARR_JIT_BACKREFERENCES).