[webkit-reviews] review granted: [Bug 234405] Remove unneeded webkit specific CSS attribute for Image Control Menu. : [Attachment 447658] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 234405: Remove unneeded webkit specific CSS attribute for Image Control
Menu.
https://bugs.webkit.org/show_bug.cgi?id=234405

Attachment 447658: Patch

https://bugs.webkit.org/attachment.cgi?id=447658&action=review




--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 447658
  --> https://bugs.webkit.org/attachment.cgi?id=447658
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447658&action=review

LGTM, with mine and Aditya's comments.

>> Source/WebCore/rendering/RenderThemeMac.mm:2317
>> +bool RenderThemeMac::isImageControl(const Element* elementPtr) const
> 
> https://bugs.webkit.org/show_bug.cgi?id=234405#c9

+1!

(Alternately — you could consider just using
`ImageControlsMac::isImageControlsButtonElement` instead of adding this helper
function on RenderThemeMac)

> LayoutTests/fast/images/image-controls-basic.html:32
> +	setInterval(() => {
> +    if (hasImageControls(elem))
> +	   testRunner.notifyDone();
> +	}, 200);

Minor nit - it looks like this test mixes spaces and tabs; let's just use
spaces?