[webkit-reviews] review granted: [Bug 234528] Harden PCM and ITP databases against crashes : [Attachment 447646] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 234528: Harden PCM and ITP databases against crashes
https://bugs.webkit.org/show_bug.cgi?id=234528

Attachment 447646: Patch

https://bugs.webkit.org/attachment.cgi?id=447646&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 447646
  --> https://bugs.webkit.org/attachment.cgi?id=447646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447646&action=review

r=me

> Source/WebKit/NetworkProcess/DatabaseUtilities.cpp:279
> +    WebCore::SQLiteTransaction transaction(m_database);

beginTransactionIfNecessary ASSERTs when on the main thread. Should we add that
assertion, too?

ASSERT(!RunLoop::isMain());