[webkit-reviews] review granted: [Bug 234525] Make it possible to enable log channels in WebKitTestRunner and DumpRenderTree : [Attachment 447629] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 234525: Make it possible to enable log channels in WebKitTestRunner and
DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=234525

Attachment 447629: Patch

https://bugs.webkit.org/attachment.cgi?id=447629&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 447629
  --> https://bugs.webkit.org/attachment.cgi?id=447629
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447629&action=review

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:124
> +	   [[NSUserDefaults standardUserDefaults] setValue:[NSString
stringWithUTF8String:options.webCoreLogChannels.c_str()]
forKey:@"WebKitLogging"];

This should be `options.webKitLogChannels.c_str()`.