[webkit-reviews] review granted: [Bug 234523] Roll ANGLE to aabfe8747d 12-17-2021 : [Attachment 447623] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 20 13:04:26 PST 2021
Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 234523: Roll ANGLE to aabfe8747d 12-17-2021
https://bugs.webkit.org/show_bug.cgi?id=234523
Attachment 447623: Patch
https://bugs.webkit.org/attachment.cgi?id=447623&action=review
--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 447623
--> https://bugs.webkit.org/attachment.cgi?id=447623
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=447623&action=review
Great to see the progress reducing the diffs from upstream. r+ from me; most
carefully reviewed the Metal backend changes, and changes.diff. A couple of
small questions; feel free to move ahead without re-review.
> Source/ThirdParty/ANGLE/ChangeLog:8
> + * ANGLE.plist:
Suggest trimming ChangeLog as before.
> Source/ThirdParty/ANGLE/changes.diff:922
> + switch_data += "#if (TARGET_OS_OSX && (__MAC_OS_X_VERSION_MAX_ALLOWED
>= 110000))\n"
Could you double-check whether these ifdefs were properly upstreamed? Thought
these diffs should have been resolved already.
More information about the webkit-reviews
mailing list