[webkit-reviews] review granted: [Bug 234159] CSP: Always use UTF-8 encoded content when checking hashes : [Attachment 446935] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 234159: CSP: Always use UTF-8 encoded content when checking hashes
https://bugs.webkit.org/show_bug.cgi?id=234159

Attachment 446935: Patch

https://bugs.webkit.org/attachment.cgi?id=446935&action=review




--- Comment #10 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 446935
  --> https://bugs.webkit.org/attachment.cgi?id=446935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446935&action=review

r=me. Could you file a bug about the unexpected http server results?

> Source/WebCore/page/csp/ContentSecurityPolicy.cpp:-371
> -    // FIXME: Compute the digest with respect to the raw bytes received from
the page.

We should remember to mark this bug resolved once this patch lands.