[webkit-reviews] review granted: [Bug 234506] [LCMS] Use std::unqiue_ptr to retain LCMS objects : [Attachment 447590] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 20 07:24:43 PST 2021


Michael Catanzaro <mcatanzaro at gnome.org> has granted Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 234506: [LCMS] Use std::unqiue_ptr to retain LCMS objects
https://bugs.webkit.org/show_bug.cgi?id=234506

Attachment 447590: Patch

https://bugs.webkit.org/attachment.cgi?id=447590&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 447590
  --> https://bugs.webkit.org/attachment.cgi?id=447590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447590&action=review

> Source/WebCore/platform/graphics/lcms/LCMSUniquePtr.h:38
> +    void operator() (cmsHPROFILE ptr) const

Why do these have to be const?


More information about the webkit-reviews mailing list