[webkit-reviews] review requested: [Bug 234387] [JSC][ARMv7] Minor code size improvements : [Attachment 447344] Patch

[bugzilla-daemon at webkit.org]

Geza Lore <glore at igalia.com> has asked	for review:
Bug 234387: [JSC][ARMv7] Minor code size improvements
https://bugs.webkit.org/show_bug.cgi?id=234387

Attachment 447344: Patch

https://bugs.webkit.org/attachment.cgi?id=447344&action=review




--- Comment #6 from Geza Lore <glore at igalia.com> ---
Comment on attachment 447344
  --> https://bugs.webkit.org/attachment.cgi?id=447344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447344&action=review

Thanks these are very helpful. Fixed all.

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2263
>> +		m_jit.storeValue(value.jsValueRegs(),
JITCompiler::addressFor(node->machineLocal()));
> 
> First define JSValueRegs valueRegs = value.jsValueRegs();

Not sure this is necessary, most other cases don't do this.