[webkit-reviews] review granted: [Bug 234480] Fix Tools/Scripts/webkitpy/w3c/test_importer.py : [Attachment 447530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 20 00:16:03 PST 2021


Manuel Rego Casasnovas <rego at igalia.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 234480: Fix Tools/Scripts/webkitpy/w3c/test_importer.py
https://bugs.webkit.org/show_bug.cgi?id=234480

Attachment 447530: Patch

https://bugs.webkit.org/attachment.cgi?id=447530&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 447530
  --> https://bugs.webkit.org/attachment.cgi?id=447530
Patch

r=me, thanks for the fix.

This seems to be failing for this test:
http://wpt.live/html/semantics/interactive-elements/the-dialog-element/top-laye
r-position.html
Should we add some kind of unit test to avoid breaking this again in the
future?


More information about the webkit-reviews mailing list