[webkit-reviews] review granted: [Bug 234299] Add a basic heuristic for collecting and extracting text from controls in ModalContainerObserver : [Attachment 447524] Rebase on trunk

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 234299: Add a basic heuristic for collecting and extracting text from
controls in ModalContainerObserver
https://bugs.webkit.org/show_bug.cgi?id=234299

Attachment 447524: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=447524&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 447524
  --> https://bugs.webkit.org/attachment.cgi?id=447524
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=447524&action=review

> Source/WebCore/page/ModalContainerObserver.cpp:182
> +    if (element.hasEventListeners(eventNames().clickEvent) ||
element.hasEventListeners(eventNames().mousedownEvent) ||
element.hasEventListeners(eventNames().mouseupEvent))

What about touch and pointer events?

> Source/WebCore/page/ModalContainerObserver.cpp:209
> +	       if (outer->hasTagName(HTMLNames::divTag) ||
outer->hasTagName(HTMLNames::spanTag) || outer->hasTagName(HTMLNames::pTag))

What about <section>?