[webkit-reviews] review granted: [Bug 234483] Keyboard shortcut to scroll to top when already at the top of the page moves to the bottom : [Attachment 447538] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 19 08:41:09 PST 2021
Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 234483: Keyboard shortcut to scroll to top when already at the top of the
page moves to the bottom
https://bugs.webkit.org/show_bug.cgi?id=234483
Attachment 447538: Patch
https://bugs.webkit.org/attachment.cgi?id=447538&action=review
--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 447538
--> https://bugs.webkit.org/attachment.cgi?id=447538
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=447538&action=review
> LayoutTests/fast/scrolling/keyboard-scrolling-home.html:19
> + await UIHelper.keyDown("home");
> + await UIHelper.renderingUpdate();
> +
> + shouldBeZero("window.scrollY");
> + finishJSTest();
> + }
> +
> + window.addEventListener('load', () => {
> + runTest();
> + }, false);
screwy indentation
More information about the webkit-reviews
mailing list