[webkit-reviews] review granted: [Bug 234441] Introduce a fast path for replacing an attribute event listener : [Attachment 447474] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alexey Shvayka
<ashvayka at apple.com>'s request for review:
Bug 234441: Introduce a fast path for replacing an attribute event listener
https://bugs.webkit.org/show_bug.cgi?id=234441

Attachment 447474: Patch

https://bugs.webkit.org/attachment.cgi?id=447474&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 447474
  --> https://bugs.webkit.org/attachment.cgi?id=447474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447474&action=review

r=me

> Source/WebCore/bindings/js/JSEventListener.cpp:86
> +    m_jsFunction = JSC::Weak<JSC::JSObject>(jsFunction);

m_jsFunction = JSC::Weak { jsFunction };

Should work and is more concise.

> Source/WebCore/bindings/js/JSEventListener.h:88
> +template<class JSMaybeErrorEventListener>

nit: I think we usually use "typename" instead of "class". Same comment below
in this file.

> Source/WebCore/dom/EventTarget.cpp:166
> +    DOMWrapperWorld& isolatedWorld = worldForDOMObject(jsEventTarget);

auto& ?