[webkit-reviews] review granted: [Bug 234216] Hide viewport-constrained elements that are detected by ModalContainerObserver : [Attachment 447388] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 17 14:55:22 PST 2021
Tim Horton <thorton at apple.com> has granted review:
Bug 234216: Hide viewport-constrained elements that are detected by
ModalContainerObserver
https://bugs.webkit.org/show_bug.cgi?id=234216
Attachment 447388: Patch
https://bugs.webkit.org/attachment.cgi?id=447388&action=review
--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 447388
--> https://bugs.webkit.org/attachment.cgi?id=447388
Patch
This seems to address Antti's concerns (though would be good to get his input,
maybe asynchronously). Maybe move your check up beyond the unconditional quirks
one?
More information about the webkit-reviews
mailing list