[webkit-reviews] review granted: [Bug 234429] Update RTCRtpScriptTransformer key frame API according latest spec proposal : [Attachment 447445] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 234429: Update RTCRtpScriptTransformer key frame API according latest spec
proposal
https://bugs.webkit.org/show_bug.cgi?id=234429

Attachment 447445: Patch

https://bugs.webkit.org/attachment.cgi?id=447445&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 447445
  --> https://bugs.webkit.org/attachment.cgi?id=447445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447445&action=review

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:154
> +	   fprintf(stderr, "RTCRtpScriptTransformer::generatetKeyFrame promise
resolution\n");

You probably don't want to commit this.

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:170
> +    fprintf(stderr,
"RTCRtpScriptTransformer::generateKeyFrame2Source/WebCore/Modules/mediastream/R
TCRtpScriptTransformer.h \n");

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:180
> +    fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest\n");

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:188
> +    fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest1\n");

Ditto

> Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:193
> +	   fprintf(stderr, "RTCRtpScriptTransformer::sendKeyFrameRequest2\n");

Ditto