[webkit-reviews] review granted: [Bug 234422] [LFC][IFC] Let computeIsFirstIsLastBoxForInlineContent update the IsFirstForLayoutBox on the display boxes : [Attachment 447422] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234422: [LFC][IFC] Let computeIsFirstIsLastBoxForInlineContent update the
IsFirstForLayoutBox on the display boxes
https://bugs.webkit.org/show_bug.cgi?id=234422

Attachment 447422: Patch

https://bugs.webkit.org/attachment.cgi?id=447422&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 447422
  --> https://bugs.webkit.org/attachment.cgi?id=447422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447422&action=review

>
Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp
:458
> +struct FirstLastInlineBoxes {
> +    HashMap<const Box*, size_t> first;
> +    HashMap<const Box*, size_t> last;
> +};

Alternatively a single HashMap with a struct with optional first/last. Might
save a hash lookup though maybe it doesn't matter.