[webkit-reviews] review granted: [Bug 234001] [css-contain][Performance test] Add test contain-paint-text-nowrap.html : [Attachment 446355] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 234001: [css-contain][Performance test] Add test
contain-paint-text-nowrap.html
https://bugs.webkit.org/show_bug.cgi?id=234001

Attachment 446355: Patch

https://bugs.webkit.org/attachment.cgi?id=446355&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 446355
  --> https://bugs.webkit.org/attachment.cgi?id=446355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446355&action=review

> PerformanceTests/ChangeLog:13
> +	   * Paint/contain-paint-nowrap.html: Added.

Might be better to have a "containment" directory, rather than a "Paint"
directory.

> PerformanceTests/Paint/contain-paint-nowrap.html:40
> +	       document.body.getBoundingClientRect();

Why the forced layout?

> PerformanceTests/Paint/contain-paint-nowrap.html:44
> +	   var isDone = false;

var -> let?

> PerformanceTests/Paint/contain-paint-nowrap.html:52
> +	   var startTime;
> +	   var height = 0;

var -> let?