[webkit-reviews] review granted: [Bug 234405] Remove unneeded webkit specific CSS attribute for Image Control Menu. : [Attachment 447397] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 234405: Remove unneeded webkit specific CSS attribute for Image Control
Menu.
https://bugs.webkit.org/show_bug.cgi?id=234405

Attachment 447397: Patch

https://bugs.webkit.org/attachment.cgi?id=447397&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 447397
  --> https://bugs.webkit.org/attachment.cgi?id=447397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447397&action=review

> Source/WebKit/ChangeLog:13
> +	   * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
> +	   (-[WKWebViewConfiguration init]):

Did you actually change anything here?

> Source/WebCore/rendering/RenderTheme.cpp:307
> +#if ENABLE(SERVICE_CONTROLS)
> +    if (ImageControlsMac::isImageControlsButtonElement(element.get()))
> +	   return ImageControlsButtonPart;
> +#endif

It's a bit weird to see macOS code in RenderTheme which has a RenderThemeMac
subclass. Can we factor this into a virtual function?