[webkit-reviews] review canceled: [Bug 234403] [Cocoa] Web Driver: WebSocket over TLS failing over WebDriver with acceptInsecureCerts on Big Sur : [Attachment 447389] Patch v1.0

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has canceled Patrick Angle
<pangle at apple.com>'s request for review:
Bug 234403: [Cocoa] Web Driver: WebSocket over TLS failing over WebDriver with
acceptInsecureCerts on Big Sur
https://bugs.webkit.org/show_bug.cgi?id=234403

Attachment 447389: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=447389&action=review




--- Comment #3 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 447389
  --> https://bugs.webkit.org/attachment.cgi?id=447389
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=447389&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:671
> +    _websiteDataStore->setAllowsAnySSLCertificateForWebSocket(allow);

I've made a mistake here. This ends up enabling/disabling insecure certs
globally, not scoped to a network session. I need to reengineer this.