[webkit-reviews] review requested: [Bug 234402] [JSC] only emit save/restore register for JIT thunks on ARM64 : [Attachment 447378] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 234402: [JSC] only emit save/restore register for JIT thunks on ARM64
https://bugs.webkit.org/show_bug.cgi?id=234402

Attachment 447378: Patch

https://bugs.webkit.org/attachment.cgi?id=447378&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 447378
  --> https://bugs.webkit.org/attachment.cgi?id=447378
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447378&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] only emit save/restore register for JIT thunks on ARM64

A better description is “Only emit pointer validation for ARM64E.”

> Source/JavaScriptCore/jit/ThunkGenerators.cpp:163
> +#endif

You’ll need to add UNUSED_PARAM for the arguments that are not used for
non-ARM64E ports.