[webkit-reviews] review granted: [Bug 234380] [LFC][IFC] Simple RTL content may need visual reordering : [Attachment 447318] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 16 06:20:45 PST 2021

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234380: [LFC][IFC] Simple RTL content may need visual reordering

Attachment 447318: Patch


--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 447318
  --> https://bugs.webkit.org/attachment.cgi?id=447318

View in context: https://bugs.webkit.org/attachment.cgi?id=447318&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:279
> +	   , paragraphContentBuilder.is8Bit() ?
StringView(paragraphContentBuilder).upconvertedCharacters() :

I think you can just call upconvertedCharacters unconditionally. It handles all
cases efficiently.

I'd keep this call as a single and use variables if needed.

More information about the webkit-reviews mailing list