[webkit-reviews] review granted: [Bug 234380] [LFC][IFC] Simple RTL content may need visual reordering : [Attachment 447318] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 234380: [LFC][IFC] Simple RTL content may need visual reordering
https://bugs.webkit.org/show_bug.cgi?id=234380

Attachment 447318: Patch

https://bugs.webkit.org/attachment.cgi?id=447318&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 447318
  --> https://bugs.webkit.org/attachment.cgi?id=447318
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447318&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:279
> +	   , paragraphContentBuilder.is8Bit() ?
StringView(paragraphContentBuilder).upconvertedCharacters() :
paragraphContentBuilder.characters16()

I think you can just call upconvertedCharacters unconditionally. It handles all
cases efficiently.

I'd keep this call as a single and use variables if needed.