[webkit-reviews] review denied: [Bug 202842] MSVC reports "wtf/RetainPtr.h(196): error C3861: 'CFAutorelease': identifier not found " with /permissive- on Windows : [Attachment 447302] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 202842: MSVC reports "wtf/RetainPtr.h(196): error C3861: 'CFAutorelease':
identifier not found " with /permissive- on Windows
https://bugs.webkit.org/show_bug.cgi?id=202842

Attachment 447302: Patch

https://bugs.webkit.org/attachment.cgi?id=447302&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 447302
  --> https://bugs.webkit.org/attachment.cgi?id=447302
Patch

I think it’s OK to put a condition in here around the parts that won’t work on
Windows, but:

1) That’s not what this patch does (and so that’s why review-).
2) I don’t think OS(WINDOWS) is the best conditional to use. I think we should
use HAVE(CFAUTORELEASE) or HAVE(AUTORELEASE) even though we need to add to
PlatformHave.h to do that.