[webkit-reviews] review granted: [Bug 203694] Rename Wasm::CodeBlock to Wasm::CalleeGroup : [Attachment 447297] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 203694: Rename Wasm::CodeBlock to Wasm::CalleeGroup
https://bugs.webkit.org/show_bug.cgi?id=203694

Attachment 447297: Patch

https://bugs.webkit.org/attachment.cgi?id=447297&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 447297
  --> https://bugs.webkit.org/attachment.cgi?id=447297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447297&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   This is not a CodeBlock. And it is confusing name to JSC::CodeBlock.

I suggest rephrasing as “And the name causes confusion with JSC::CodeBlock,
which is not at all related.”