[webkit-reviews] review granted: [Bug 234370] Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere : [Attachment 447295] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 234370: Add a "NotificationData" object to encompass local
Notification-related parameters, instead of passing tons of them around
everywhere
https://bugs.webkit.org/show_bug.cgi?id=234370

Attachment 447295: Patch v1

https://bugs.webkit.org/attachment.cgi?id=447295&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 447295
  --> https://bugs.webkit.org/attachment.cgi?id=447295
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=447295&action=review

> Source/WebCore/Modules/notifications/NotificationData.h:49
> +    encoder << title << body << iconURL << tag << language << direction <<
originString << notificationID;

I feel like traditionally we do one-per-line, though there's nothing wrong with
this.