[webkit-reviews] review granted: [Bug 233945] ActiveDOMObject::suspendIfNeeded() should not be called within constructors : [Attachment 447270] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 233945: ActiveDOMObject::suspendIfNeeded() should not be called within
constructors
https://bugs.webkit.org/show_bug.cgi?id=233945

Attachment 447270: Patch

https://bugs.webkit.org/attachment.cgi?id=447270&action=review




--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 447270
  --> https://bugs.webkit.org/attachment.cgi?id=447270
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447270&action=review

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:530
> +    Ref<IDBIndex> referencedIndex { index };

Since we’re touching this code, it can likely be changed to Ref instead of
Ref<IDBIndex> since we have type deduction now.

> Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:753
> +    auto index = IDBIndex::create(*scriptExecutionContext(), info,
objectStore);
> +    return index.moveToUniquePtr();

Should just be able to write:

    return IDBIndex::create(*scriptExecutionContext(), info, objectStore);

Move construction of unique_ptr from UniqueRef should work.