[webkit-reviews] review granted: [Bug 233945] ActiveDOMObject::suspendIfNeeded() should not be called within constructors : [Attachment 447234] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 233945: ActiveDOMObject::suspendIfNeeded() should not be called within
constructors
https://bugs.webkit.org/show_bug.cgi?id=233945

Attachment 447234: Patch

https://bugs.webkit.org/attachment.cgi?id=447234&action=review




--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 447234
  --> https://bugs.webkit.org/attachment.cgi?id=447234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447234&action=review

r=me with suggestions.

> Source/WebCore/Modules/indexeddb/IDBIndex.cpp:45
> +std::unique_ptr<IDBIndex> IDBIndex::create(ScriptExecutionContext& context,
const IDBIndexInfo& info, IDBObjectStore& objectStore)

We may want to return a UniqueRef instead since this cannot return null.

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:58
> +std::unique_ptr<IDBObjectStore>
IDBObjectStore::create(ScriptExecutionContext& context, const
IDBObjectStoreInfo& info, IDBTransaction& transaction)

ditto.