[webkit-reviews] review granted: [Bug 234328] Twitter scroll stutter: ensure that CA backing store is always deallocated on the main thread : [Attachment 447186] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 234328: Twitter scroll stutter: ensure that CA backing store is always
deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=234328

Attachment 447186: Patch

https://bugs.webkit.org/attachment.cgi?id=447186&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 447186
  --> https://bugs.webkit.org/attachment.cgi?id=447186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447186&action=review

Not the least frightening patch I've ever seen.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-33104
> -				7B582DD82716F55B004B92D0 /* (null) in Headers
*/,

This seems bad

>
Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedRelease
r.mm:82
> +	       RunLoop::main().dispatch([] {

Isn't it the scrolling thread runloop you're racing here (freeing the
transaction), not the main thread?