[webkit-reviews] review granted: [Bug 234314] http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky : [Attachment 447163] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 234314: http/tests/security/basic-auth-subresource.html and some other http
auth tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=234314

Attachment 447163: Patch

https://bugs.webkit.org/attachment.cgi?id=447163&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 447163
  --> https://bugs.webkit.org/attachment.cgi?id=447163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447163&action=review

> Source/WebCore/platform/network/ProtectionSpaceHash.h:43
> +	   WTF::add(hasher, protectionSpace.host());
> +	   WTF::add(hasher, protectionSpace.port());
> +	   WTF::add(hasher, protectionSpace.serverType());
> +	   WTF::add(hasher, protectionSpace.authenticationScheme());
> +	   if (!protectionSpace.isProxy())
> +	       WTF::add(hasher, protectionSpace.realm());

Should not need the WTF:: prefixes.