[webkit-reviews] review granted: [Bug 234316] [JSC] OpInstanceofCustom should be in CommonSlowPaths : [Attachment 447161] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 15:38:14 PST 2021


Alexey Shvayka <ashvayka at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 234316: [JSC] OpInstanceofCustom should be in CommonSlowPaths
https://bugs.webkit.org/show_bug.cgi?id=234316

Attachment 447161: Patch

https://bugs.webkit.org/attachment.cgi?id=447161&action=review




--- Comment #2 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 447161
  --> https://bugs.webkit.org/attachment.cgi?id=447161
Patch

This change looks good since Symbol.hasInstance hasn't get much usage on the
web, and it will also simplify https://bugs.webkit.org/show_bug.cgi?id=216816,
which I pledge to get thoroughly benchmarked and reviewed during / right after
the �� break.

r=me is JSTests/microbenchmarks/instanceof-* are neutral (especially the
instanceof-bound.js, which takes this path).


More information about the webkit-reviews mailing list