[webkit-reviews] review granted: [Bug 226088] [CMake] Cannot link libTestRunnerInjectedBundle.so in non unified build : [Attachment 447125] Rebased patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 226088: [CMake] Cannot link libTestRunnerInjectedBundle.so in non unified
build
https://bugs.webkit.org/show_bug.cgi?id=226088

Attachment 447125: Rebased patch

https://bugs.webkit.org/attachment.cgi?id=447125&action=review




--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 447125
  --> https://bugs.webkit.org/attachment.cgi?id=447125
Rebased patch

LGTM with a nit to change before landing -- and thanks to looking into this,
I hadn't had the time to bring myself to fix it yet ��️

View in context: https://bugs.webkit.org/attachment.cgi?id=447125&action=review

> Source/WebCore/testing/Internals.h:1006
> +    // directly with libWebCore (e.g. with non-unified builds)

I think we don't want to mention here anything about unified vs. non-unified
builds, because with an unlucky combination of unified sources the issue could
come up anyway. The rest of the comment is good to have it here for clarity,
as this may not be obvious to the people reading the code =)