[webkit-reviews] review granted: [Bug 233677] Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability: part 3 : [Attachment 447107] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 00:36:18 PST 2021


youenn fablet <youennf at gmail.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 233677: Distinguish contiguous SharedBuffer from non-contiguous one and
guarantee immutability: part 3
https://bugs.webkit.org/show_bug.cgi?id=233677

Attachment 447107: Patch

https://bugs.webkit.org/attachment.cgi?id=447107&action=review




--- Comment #32 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 447107
  --> https://bugs.webkit.org/attachment.cgi?id=447107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447107&action=review

> Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:44
> +TEST_F(FragmentedSharedBufferTest, createWithContentsOfMissingFile)

Are some of these tests worth being duplicated for SharedBuffer as well?


More information about the webkit-reviews mailing list