[webkit-reviews] review requested: [Bug 226088] [CMake] Cannot link libTestRunnerInjectedBundle.so in non unified build : [Attachment 447105] Tentative patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 20:43:13 PST 2021


Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 226088: [CMake] Cannot link libTestRunnerInjectedBundle.so in non unified
build
https://bugs.webkit.org/show_bug.cgi?id=226088

Attachment 447105: Tentative patch

https://bugs.webkit.org/attachment.cgi?id=447105&action=review




--- Comment #4 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 447105

  --> https://bugs.webkit.org/attachment.cgi?id=447105&action=review

Tentative patch

Patch based on Adrian's, building unified/non-unified on top of r286914 (Last
sunday). It replaces the alias for the MediaSession enum in the Internals.h
with separate enum with the same values. Not sure if it's the best approach,
though.


More information about the webkit-reviews mailing list