[webkit-reviews] review granted: [Bug 234265] Teach webpushtool to register and "host" the daemon : [Attachment 447074] Patch v2

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 234265: Teach webpushtool to register and "host" the daemon
https://bugs.webkit.org/show_bug.cgi?id=234265

Attachment 447074: Patch v2

https://bugs.webkit.org/attachment.cgi?id=447074&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 447074
  --> https://bugs.webkit.org/attachment.cgi?id=447074
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=447074&action=review

> Source/WebKit/webpushd/WebPushDaemon.mm:190
> +    broadcastDebugMessage((JSC::MessageLevel)4, "===\nCurrent
connections:");

Does this really not have a name?

> Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h:55
> +    Yes,
> +    No,

Oh dear, please flip all of these enums to save people who use debuggers.