[webkit-reviews] review granted: [Bug 234266] Attachment does not update after markup. : [Attachment 447062] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 234266: Attachment does not update after markup.
https://bugs.webkit.org/show_bug.cgi?id=234266

Attachment 447062: Patch

https://bugs.webkit.org/attachment.cgi?id=447062&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 447062
  --> https://bugs.webkit.org/attachment.cgi?id=447062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447062&action=review

> Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm:158
> +	      
_menuProxy->page()->didInvalidateDataForAttachment(*apiAttachment.get());

Not new in this patch, but we should weakly capture WebPageProxy here (instead
of accessing it through the raw pointer to _menuProxy.)