[webkit-reviews] review granted: [Bug 234266] Attachment does not update after markup. : [Attachment 447062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 14:15:26 PST 2021

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 234266: Attachment does not update after markup.

Attachment 447062: Patch


--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 447062
  --> https://bugs.webkit.org/attachment.cgi?id=447062

View in context: https://bugs.webkit.org/attachment.cgi?id=447062&action=review

> Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm:158
> +	      

Not new in this patch, but we should weakly capture WebPageProxy here (instead
of accessing it through the raw pointer to _menuProxy.)

More information about the webkit-reviews mailing list