[webkit-reviews] review granted: [Bug 234181] REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS : [Attachment 446890] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 08:42:55 PST 2021
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 234181: REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on
iOS
https://bugs.webkit.org/show_bug.cgi?id=234181
Attachment 446890: Patch
https://bugs.webkit.org/attachment.cgi?id=446890&action=review
--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 446890
--> https://bugs.webkit.org/attachment.cgi?id=446890
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=446890&action=review
> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:308
> + RELEASE_LOG_ERROR(WebRTC, "NetworkRTCUDPSocketCocoaConnections
failed processing UDP data with error %d", nw_error_get_error_code(error));
Nit: if you log `errorCode` you won't have to call nw_error_get_error_code()
again
More information about the webkit-reviews
mailing list