[webkit-reviews] review granted: [Bug 227445] Text decoration renders on top of text when it should be below : [Attachment 446955] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 227445: Text decoration renders on top of text when it should be below
https://bugs.webkit.org/show_bug.cgi?id=227445

Attachment 446955: Patch

https://bugs.webkit.org/attachment.cgi?id=446955&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 446955
  --> https://bugs.webkit.org/attachment.cgi?id=446955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446955&action=review

> Source/WebCore/rendering/TextDecorationPainter.cpp:317
> +void TextDecorationPainter::strokeLineThrough(const Color& color, float
thickness, const FloatPoint& localOrigin)

This use of "stroke" here is easily confused with "text stroke". Just call it
paintLineThrough() and limit use the term "stroke" in the code.