[webkit-reviews] review granted: [Bug 234097] Teach the sampling profiler how to display origin data for B3 Wasm : [Attachment 446895] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 234097: Teach the sampling profiler how to display origin data for B3 Wasm
https://bugs.webkit.org/show_bug.cgi?id=234097

Attachment 446895: patch

https://bugs.webkit.org/attachment.cgi?id=446895&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 446895
  --> https://bugs.webkit.org/attachment.cgi?id=446895
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446895&action=review

r=me if EWS gets green.

>>> Source/JavaScriptCore/wasm/WasmCalleeRegistry.h:88
>>> +	 }
>> 
>> Why don't we put m_codeOriginMap to the Callee instead of holding it in this
hashmap?
> 
> I didn't want to grow Callee by one pointer for a field that's non null only
for debugging.

I think, if it is once enabled, it consumes significant amount of memory
instead (HashTable is super large, it typically allocates 2x-4x more memory to
maintain O(1) access. And we need to hold pair of Callee*, Box<>, which is 2x
more than just having a pointer to Box<>), but so long as it is enabled in a
certain case, I'm OK.