[webkit-reviews] review granted: [Bug 234184] ContextDestructionObserver::m_scriptExecutionContext should be private : [Attachment 446836] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 11 09:16:03 PST 2021


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 234184: ContextDestructionObserver::m_scriptExecutionContext should be
private
https://bugs.webkit.org/show_bug.cgi?id=234184

Attachment 446836: Patch

https://bugs.webkit.org/attachment.cgi?id=446836&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 446836
  --> https://bugs.webkit.org/attachment.cgi?id=446836
Patch

Some pre-existing places are using *scriptExecutionContext() and it is not
clear whether it is guaranteed to not be null.

View in context: https://bugs.webkit.org/attachment.cgi?id=446836&action=review

> Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp:65
> +    auto context = scriptExecutionContext();

auto*


More information about the webkit-reviews mailing list