[webkit-reviews] review granted: [Bug 234174] Expose a frameRate property to Web Animations : [Attachment 446885] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 234174: Expose a frameRate property to Web Animations
https://bugs.webkit.org/show_bug.cgi?id=234174

Attachment 446885: Patch

https://bugs.webkit.org/attachment.cgi?id=446885&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 446885
  --> https://bugs.webkit.org/attachment.cgi?id=446885
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446885&action=review

> LayoutTests/webanimations/frame-rate/animation-frame-rate.html:17
> +    for (let value of ["low", "high", "highest", "auto"]) {

forEach would look nicer here, but that's just me :)

> LayoutTests/webanimations/frame-rate/animation-frame-rate.html:29
> +    for (let value of ["default", "120", null, undefined, [], {}]) {

Nice. Took me a moment to work out the "120" case.