[webkit-reviews] review granted: [Bug 234188] Automatically forbid JS execution when we throw a TerminationException. : [Attachment 446848] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 17:32:16 PST 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 234188: Automatically forbid JS execution when we throw a
TerminationException.
https://bugs.webkit.org/show_bug.cgi?id=234188

Attachment 446848: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=446848&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 446848
  --> https://bugs.webkit.org/attachment.cgi?id=446848
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=446848&action=review

r=me

> Source/JavaScriptCore/runtime/VM.h:1123
> +    bool m_forbidExecutionOnTermination { false };

Since forbidExecutionOnTermination is verb and there is m_executionForbidden, I
think renaming it to m_executionOnTerminationForbidden is better.


More information about the webkit-reviews mailing list