[webkit-reviews] review granted: [Bug 234189] Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher : [Attachment 446850] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 17:27:57 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 234189: Momentum Event Dispatcher: Magic Mouse doesn't use momentum event
dispatcher
https://bugs.webkit.org/show_bug.cgi?id=234189

Attachment 446850: Patch

https://bugs.webkit.org/attachment.cgi?id=446850&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 446850
  --> https://bugs.webkit.org/attachment.cgi?id=446850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446850&action=review

> Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:123
> +	   return fromFixedPoint([(NSNumber *)valueCF.get() floatValue]);

Do we need to guard against it not being a CFNumber?


More information about the webkit-reviews mailing list