[webkit-reviews] review granted: [Bug 234045] Move matchSystemFontUse to SystemFontDatabase : [Attachment 446460] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 15:01:02 PST 2021

Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 234045: Move matchSystemFontUse to SystemFontDatabase

Attachment 446460: Patch


--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446460
  --> https://bugs.webkit.org/attachment.cgi?id=446460

View in context: https://bugs.webkit.org/attachment.cgi?id=446460&action=review

> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h:128
> +    Vector<AtomString> m_textStyles;

Thinking about this, I think you're right, this is probably better.

More information about the webkit-reviews mailing list