[webkit-reviews] review granted: [Bug 233984] Make FontCache allowlist thread safe : [Attachment 446310] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 14:49:11 PST 2021


Myles C. Maxfield <mmaxfield at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 233984: Make FontCache allowlist thread safe
https://bugs.webkit.org/show_bug.cgi?id=233984

Attachment 446310: Patch

https://bugs.webkit.org/attachment.cgi?id=446310&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 446310
  --> https://bugs.webkit.org/attachment.cgi?id=446310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446310&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1225
> +    Locker locker { Allowlist::lock };

This might be an opportunity for performance improvement, since this allowlist
is only used for testing.


More information about the webkit-reviews mailing list