[webkit-reviews] review granted: [Bug 191379] WKWebView doesn’t respond to -copyFont: and -pasteFont: : [Attachment 446795] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 191379: WKWebView doesn’t respond to -copyFont: and -pasteFont:
https://bugs.webkit.org/show_bug.cgi?id=191379

Attachment 446795: Patch

https://bugs.webkit.org/attachment.cgi?id=446795&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 446795
  --> https://bugs.webkit.org/attachment.cgi?id=446795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446795&action=review

r=mews

> Source/WebCore/editing/mac/EditorMac.mm:109
> +void Editor::platformCopyFont()

We should file a followup to unify this code with the WebKitLegacy
implementation in WebHTMLView.

> Source/WebCore/editing/mac/EditorMac.mm:125
> +void Editor::platformPasteFont()

Same, for this.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4174
> +	   // FIXME: Does iOS have a different pasteboard for fonts?

iOS does not support a dedicated font pasteboard, no. Falling back to the
general pasteboard is probably okay here (and we can remove the FIXME).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4186
> +	   // FIXME: Does iOS have a different pasteboard for fonts?

Ditto.

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1555
> +	   // FIXME: Does iOS have a different pasteboard for fonts?

Ditto.

> Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:663
> +	   grantAccessToCurrentPasteboardData(NSFontPboard);

Can you use `NSPasteboardNameFont` instead of suppressing deprecation warnings?