[webkit-reviews] review granted: [Bug 234128] Revoke attachment element sandbox extensions : [Attachment 446776] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 234128: Revoke attachment element sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=234128

Attachment 446776: Patch

https://bugs.webkit.org/attachment.cgi?id=446776&action=review




--- Comment #15 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 446776
  --> https://bugs.webkit.org/attachment.cgi?id=446776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446776&action=review

r=me, but please consider the naming and adding a comment to reduce confusion
about this new method.

> Source/WebCore/PAL/pal/spi/cocoa/ISIconManagerSPI.h:28
> + at interface ISIconManager : NSObject

If this is defined in an internal header, shouldn't we do the usual "#if
USE(APPLE_INTERNAL_SDK)" thing and grab it directly?

> Source/WebKit/ChangeLog:10
> +	   ISIconManager.

Maybe we should name this "consumeAndRevokeAttachmentElementSandboxExtensions"
or something, and add a comment in it that the extensions are not needed after
the ISIconManager is initialized?