[webkit-reviews] review granted: [Bug 234168] Momentum Event Dispatcher: Tail frames are the wrong velocity if momentum event dispatch rate doesn't match screen refresh rate : [Attachment 446783] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 234168: Momentum Event Dispatcher: Tail frames are the wrong velocity if
momentum event dispatch rate doesn't match screen refresh rate
https://bugs.webkit.org/show_bug.cgi?id=234168

Attachment 446783: Patch

https://bugs.webkit.org/attachment.cgi?id=446783&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 446783
  --> https://bugs.webkit.org/attachment.cgi?id=446783
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446783&action=review

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp:295
> +    DisplayProperties properties;
> +    properties.displayID = displayID;
> +    properties.nominalFrameRate =
nominalFramesPerSecond.value_or(WebCore::FullSpeedFramesPerSecond);

auto properties = DisplayProperties { displayID,
nominalFramesPerSecond.value_or(WebCore::FullSpeedFramesPerSecond) } ?

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:78
> +	   float nominalFrameRate;

Use the FramesPerSecond type?

> Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.h:144
> +	   float displayNominalFrameRate { 0 };

Is this a frames per second, or a frame duration? If the former, can it use
FramesPerSecond?