[webkit-reviews] review granted: [Bug 234117] Use simpler idioms for std::less and std::greater possible in modern C++ : [Attachment 446657] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 10 10:07:35 PST 2021


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 234117: Use simpler idioms for std::less and std::greater possible in
modern C++
https://bugs.webkit.org/show_bug.cgi?id=234117

Attachment 446657: Patch

https://bugs.webkit.org/attachment.cgi?id=446657&action=review




--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 446657
  --> https://bugs.webkit.org/attachment.cgi?id=446657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446657&action=review

> Source/WTF/wtf/ListDump.h:124
> +    return sortedListDump(list, std::less<>(), comma);

Is there a reason why std::less() does not work here? Maybe because it's in an
uninstantiated context?


More information about the webkit-reviews mailing list