[webkit-reviews] review granted: [Bug 233563] Web Inspector: Computed Panel: Group CSS variables by value type : [Attachment 446718] Patch 1.5

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted Razvan Caliman
<rcaliman at apple.com>'s request for review:
Bug 233563: Web Inspector: Computed Panel: Group CSS variables by value type
https://bugs.webkit.org/show_bug.cgi?id=233563

Attachment 446718: Patch 1.5

https://bugs.webkit.org/attachment.cgi?id=446718&action=review




--- Comment #20 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 446718
  --> https://bugs.webkit.org/attachment.cgi?id=446718
Patch 1.5

View in context: https://bugs.webkit.org/attachment.cgi?id=446718&action=review

r=me

> LayoutTests/inspector/css/variableStylesByType.html:23
> +		   InspectorTest.assert(cssStyles, `Should find CSS Styles for
DOM Node.`);

As Devin mentioned on bug 233372, `styleForNode` is guaranteed to return a
`WI.DOMNodeStyles` so this assertion is not necessary.

> LayoutTests/inspector/css/variableStylesByType.html:46
> +	   ]

Style/NIT: Missing trailing comma

> LayoutTests/inspector/css/variableStylesByType.html:58
> +	   ]

Ditto :46

> LayoutTests/inspector/css/variableStylesByType.html:70
> +	   ]

Ditto :46

> LayoutTests/inspector/css/variableStylesByType.html:82
> +	   ]

Ditto :46

> LayoutTests/inspector/css/variableStylesByType.html:106
> +	   ]

Ditto :46